fix(analytics): undefined file is created on every command #4177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When analytics are enabled,
undefined
file is created at the location where a command is executed. This is because the$options.analyticsLoggingFile
is undefined, but we've set it as args to the spawned Analytics process. The value in the child process is the string "undefined", so that's why CLI always creates this file.Pass the path to file only when it is passed by user.
PR Checklist
What is the current behavior?
When analytics are enabled, CLI always produces file called
undefined
, in which it saves the information what has been tracked.What is the new behavior?
When analytics are enabled, CLI will produce file with name specified by user with
--analyticsLogFile <name>
, in which it saves the information what has been tracked.Part of the implementation of: #4152